Daily Lucky Numbers:
8
12
19
29
39
40

SMF Banner Bar

Started by Chen Zhen, July 08, 2022, 11:51:45 PM

Previous topic - Next topic

Chen Zhen

Quote from: Dave on October 16, 2022, 11:48:24 AMSorry to bother you but how do I change the size of the text in the bar?

You had '.quizbanner { fontsize: 1.1rem; }' I upped that to 1.2rem and larger but it makes no difference

You forgot the hyphen.

quizbanner { font-size: 1.1rem; }


Chen Zhen


I made a small mistake within the regex for filtering that input where the range quantifier has to be escaped when not using it for a range  :-[  inside square brackets.

Thanks for the report!



Version 1.5 is now available.

Changes:
+   Changed:   unique function to determine if enabled
+   Changed:    buffer not parsed when disabled
!   Fixed:      regex meta-character (hyphen) inside square brackets escaped

Dave

Thanks Chen.

I tried all manner of variations on that including adding the hyphen, that was after I went to w3schools to see what I should put in.

Chen Zhen

It was likely because of the improper regex I used to filter the input which removed it when saved.
This should work fine now for version 1.5+.

Dave

A request please?

Is it possible, if not too difficult, to have an additional 'Save' button closer to the top of the banner admin page please?

It would be similar to the image attached.

The reason I ask is because when you're changing text/code etc you have to scroll all the way to the bottom of the page to save, and when you have quite a few themes, as I do on my main site, then it's quite a way down, and if you've messed up then you have to do it all again

Thanks

Chen Zhen


It uses SMF's generic template whereas I just set up the Source file and it creates the save button at the bottom of the template.
I can do it with its current format but it'll be with some JavaScript manipulation of the HTML.

There is also the option of making a custom template but that's more work.
I'll look at it this week and release something for you.


Chen Zhen

#21
Download the attachment & use it to replace the file in your Sources path.
It adds a SAVE button to each of the template settings (saves all settings on the page).

Lat me  know if that works for you.

Dave


Dave

Quote from: Chen Zhen on December 12, 2022, 12:55:07 AMDownload the attachment & use it to replace the file in your Sources path.
It adds a SAVE button to each of the template settings (saves all settings on the page).

Lat me  know if that works for you.



I know it's been a while but look at the images. You see that it works for some themes on my DJ site and on the quiz site it works for other themes but not the same on both, well not all the themes anyway.

There is no rush for this it works a lot better than it did, so thank you for that.

Chen Zhen

Each theme will give unique options for the parent ID which you are leaving blank.
If the bar is not showing up properly or not at all, have you tried to adjust that setting for each theme?

Or... are you just referring to that save button that is added to every theme option?

Dave

Quote from: Chen Zhen on January 04, 2023, 08:48:43 PMOr... are you just referring to that save button that is added to every theme option?

Yes, it's not putting a save into each theme. I posted the images to show that it's not limited to just one site, as you can see in djbanner, the Steyle theme has the save, but in the qzbanner image you'll see that the save button isn't there.

As I said this is not a problem as there is now a save button closer to the top of the page which is what I requested