Battle 1.0_RC8.0 BETA-UD-X

[SA]

another little one

action=battle;sa=quest
Sources\BattleMain.php on line 391
Undefined index: quest_completions

you probaly do but here goes

do you have
$db_show_debug = true;
in your settings.php
errros jump out with that enabled

[Fog]

can some one pls explain the campains to me?

Campaigns came about as a way to end the game or declare a winner.

My users wanted to know if there was a way to end the game rather than a FINAL QUEST that reset the game.

If you want the campaign to start on and end on a certain day you can set that up in the campaign settings.  Then you go back to Quests and you can add them to the campaigns at that point.  23 quests per campaign is the max if I remember right.

[SA]

aha i see now good call with the campains when i added the final quest i wasnt realy too sure on that myself i guess it was just a dirty way of ending the game 

[Fog]

When I changed up from monsters to tanks it made sense to have a way to create missions or campaigns with certain quests you had to complete. UD has done a great job.

[Tom]

Getting duplicating fields on a forum thread page with Battle 1.13, anyone else?

[Fog]

I'm good on my end...

can you turn off that feature and see if both of them go away or just one?

[Tom]

Yep, it deletes both of the instances when I disable.

[Chen Zhen]

Tom,

  Somehow when uninstalling an older version of the mod you must have ignored a parse error?
Check the file: /Themes/default/Display.template.php

Look for this:

Code Select Expand


                        if ($modSettings['enable_sts_post'])
{
$check = 999 * (!empty($user_info['hp']) ? $user_info['hp'] : 999) * (!empty($user_info['energy']) ? $user_info['energy'] : 999) * (!empty($user_info['stamina']) ? $user_info['stamina'] : 999) * (!empty($user_info['exp']) ? $user_info['exp'] : 999);
echo '
        <li>
    <span style="' . (allowedTo('view_battle') && $modSettings['enable_battle'] == 1 ? 'display:inline;' : 'display:none;') . '">
<img border="0" src="' . $settings['images_url'] . '/battle/bomb.png" alt="" style="vertical-align:top;" /> ' . $txt['battle_statsA'] . ': ' . $message['member']['atk'] .'
<br />
<img border="0" src="' . $settings['images_url'] . '/battle/shield.png" alt="" style="vertical-align:top;" /> ' . $txt['battle_statsD'] . ': ' . $message['member']['def'] . '
<span style="' . ($modSettings['battle_enable_membattle'] == 1 ? 'display:inline;' : 'display:none;') . '">
<br />
<img border="0" src="' . $settings['images_url'] . '/battle/battle_sword.gif" alt="" style="vertical-align:top;" />
<a href="' . $scripturl . '?action=battle;sa=fight;attack=' . $message['member']['id'] . ';session=' . $context['session_id'] . $check . ';#battle_main">' . $txt['battle_statsATK'] . '</a>
</span>
    </span>
</li>';
}


... There is probably 2 instances of the above code due to some sort of uninstall issue.
    Remove one instance of the above edit if you see two of them (on top of each other).

[Tom]

I actually just commented that exact code out and fixed it before coming back. Found it! I was searching for a part of the code that wasn't present in both, only one. >.<

Thanks!

[Chen Zhen]

SA,

  Yes I am aware of the undefined error which occurs when first starting up campaigns. I have already patched it for the next release. Atm it is a misdemeanor and will not cause anything to malfunction therefore I will not update until I have more to add to Battle.

Fog,

  Yes the history and stats do not update until clicking to another page. It updates them at the time it happens but does not display it immediately until you navigate to the next page.

[Fog]

UD...I got a total of 21 EXP points for the one kill...9 upon killing the member and another 11 after I navigated away from the page that displayed that I gained 9 EXP....just thought it was double dipping on one outcome.

BTW, Both are random and don't always occur...

[Chen Zhen]

Pending:

- look at experience gains for battling members
- fix evolution setting in monster edit template/source
- add option to set stat gains per monster (this way defeating tougher monsters can result in more gains)
(current settings can be for battling members)
- who's in battle missing battle.png icon (sword)
- battle config default settings source code needs to update members table defaults
- double check battle-members level restriction (either not working or admins are not checking the option)
- check reports of double clicking causing incorrect behavior
- fix single undefined error (already done)
- daily limit for attacking members (overall total)
- atk and def need to be added to random affected stats during battle/explore
- fix allowance of decimals when buying from the shop
- need more ways to gain stat points (ie. custom explore)
- leveling up should be automatic (or put admin option to allow auto leveling up)
- add options to sort list for battling members
- testing reveals sometimes campaign based quests can only be played if the campaign is opted in the dropdown -> fix this!!
- campaigns not set to wait for other members are still waiting?! - needs to be fixed
- SMF report suggests changing currency designation causes error in member battle

Some more interesting ideas: http://www.simplemachines.org/community/index.php?action=profile;u=47189

... I will adjust/fix the above and then we move on to other requests.

[Fog]

- double check battle-members level restriction (either not working or admins are not checking the option)

This works for me...I've been testing this out tonight.

fix evolution setting in monster edit template/source

I've tried this but haven't seen how it really works....has potential.

[Chen Zhen]

fix evolution setting in monster edit template/source

I've tried this but haven't seen how it really works....has potential.

  It was working but I messed with the admin inputs on the last version and now it will not except any setting for it while editing a monster. I have not looked but it is an easy fix.

[SA]

SA,

  Yes I am aware of the undefined error which occurs when first starting up campaigns. I have already patched it for the next release. Atm it is a misdemeanor and will not cause anything to malfunction therefore I will not update until I have more to add to Battle.

yes i know it not a show stopper it still a bug that is why i reported it