Daily Lucky Numbers:
19
23
24
43
44
48

Quickbuttons have gone!

Started by Dave, May 18, 2023, 06:27:27 AM

Previous topic - Next topic

Dave

Hi Chen,

I was going to quote you in a post but when I looked the quickbuttons seems to have disappeared.

I changed to SMF Curve theme and it's still the same as per the images below.

I'm not aware that there is an option to remove those from Admin so I thought I'd let you know in case it's a site coding issue

Dave

OK I now know what this is. I installed the latest version of the portal 1.39.2 and for some reason it blocks the quickbuttons on all sites I visit.

I have re-installed the original 1.39 version and everything is working fine now

Dave

I tried to go and edit that last post but I can't, I should add that there are still no quickbuttons on here

Dave

OK I should have said that all the sites, including my test site, that I installed the new portal don't show the quickbuttons.

I wonder what people did before the edit button came along? I suppose there were a lot more posts  ;D

Dave

I have another issue now which seems linked to the portal.

In the images below you'll see that I have gone to my profile to change the theme. Instead of going across the page 100% they previews are on 50%.
I have done a browser inspect and it seems that the portal is having some effect, you'll see the info better in the second image


Chen Zhen

I'll look at it this weekend.
The quick buttons are working for me.

Chen Zhen

Do they appear when you're Admin?
If so.. I know what I did wrong.

Dave

No they didn't show up at all. I didn't check if they worked for members. They're still not working on here for me

Chen Zhen


Try downloading the same package again and try it out.
Let me know if the problem is fixed.

Thanks.

Dave

#9
Quote from: Chen Zhen on May 18, 2023, 05:58:50 PMTry downloading the same package again and try it out.
Let me know if the problem is fixed.

Thanks.


Thanks Chen

It's fixed, on here and on my test site and Quizland, as far as the quickbuttons are concerned but not the narrowing of the theme selection, but, I think I know why that's happening. I THINK it's because there is duplicate code somewhere, I vaguely remember it doing this before. I will check and get back to you on that bit

UPDATE: I have uninstalled the portal and the theme select works just fine and goes full width as it should. I checked for files left over after the uninstall and removed code that wasn't removed by the mod. The files affected are 'Display.template' around line 229 and 'Login.template' around line 268.

I also uploaded a backup of the Sources and Themes folders as I say it works fine without the portal installed as soon as I install the portal the theme select goes back to 50% width.

It's not causing errors so it can stay as it is for the time being. I'm on holiday after today and wont have access for at least a week

Chen Zhen

So it left code in that file but didn't show the problem when Uninstalling the mod? Usually it will show a parse error.

Thanks for reporting the problem.. I will take a look at it.

Enjoy your holiday!

Dave


Dave

It's seems that there maybe more to this than meets the eye. I have the latest portal version installed on the test site and it's fine. The theme select is full width as it should be, so that means that something on Quizland is conflicting with both.

As I said before I'll look into it when I get back.

I might have to strip Quizland and start again and then reinstall all the mods

Chen Zhen

It looks like there's a big gap above your theme block.
It's an empty cell that has a fixed height. I don't have admin access to the portal on your site at the moment to mess with it so I guess I'll have to try to duplicate it on a local.


I have to work on the portal so it doesn't mess with the mobile nav drop-down.
Most of the newer themes are mobile friendly so I have to reconfigure the bootstrap to change some stuff but not others.

The one thing I liked about EhPortal in the past was how I got the forum page to look compared to the SMF default.
It's much easier to read on responsive mobile with its forced css reconfiguration (bootstrap).
Unfortunately on some themes and for some mods it fails to do it any justice.
It's all due to the bootstrap in the hooks file which needs a total rework.
Plus the portal itself uses div tables which is ok but I should have went with a flex container.

 

Dave

Quote from: Chen Zhen on May 19, 2023, 09:28:44 PMI don't have admin access to the portal on your site at the moment to mess with it so I guess I'll have to try to duplicate it on a local.

You now have admin portal access.

Thanks again Chen