Battle v1.15 Beta1
Download:
http://s000.tinyupload.com/index.php?file_id=00095189726634177448
Changes:
! fixed shoutbox refresh issue (now redirects to current sub action)
Battle v1.15 Beta2
Download:
http://s000.tinyupload.com/index.php?file_id=93143270784261239628
Changes:
! fixed adding campaigns issue
! fixed undefined array where no campaigns exist
Thanks. :)
Quote from: underdog on February 03, 2014, 12:07:09 AM
Battle v1.15 Beta2
Download:
http://s000.tinyupload.com/index.php?file_id=93143270784261239628
Changes:
! fixed adding campaigns issue
! fixed undefined array where no campaigns exist
Sweet, I'm going to install this patch in my next site update.
Please remember to always uninstall and delete any old versions prior to updating. No Battle data will be lost with the update.
Pending:
+ game mode to have membergroups compete against each other (this can apply to any existing Battle Mode) ie. name it -> current mode ~ Battalions
+ display membergroup score tallies on game stats template (option to toggle views)
+ add admin option/mode so it can be set where users have to acknowledge they wish to participate in the current game else it ignores their user name for various game modes & member battles
+ add option (admin setting) to require users to complete member battles and/or monster battles for campaigns in addition to the current quest requirements
+ battle container should be refreshed for game play without refreshing the entire page (manipulate the container id)
+ change template for battling members/monsters to show avatars and/or monster icons + some sort of visual effects
+ add option for sound effects using premiumbeat mod to facilitate this option (ya let me push my other mod)
+ option to restrict monsters to a specific campaign
! divide functions into more files due to reported ftp issues caused by some large file sizes
! correct some reported language/grammar
I can set it up so that an admin can disable Battle and/or Explore on the battle home page but have those type of battles available on the quest page as part of a campaign. This will allow restricting specific monsters to certain campaigns as Fog previously suggested.
Could you maybe add a feature that forces users to use a certain theme?
Since this bugs out on the Fresh Looks theme.
And I have another bug report for you. When you click on the "go back" arrow without saving a campaign and then try to delete it... You get this lovely error.
Table 'arpegi_be.smf_battle_campaign_5' doesn't exist
File: /customers/b/f/a/arpegi.be/httpd.www/Sources/BattleQuests.php
Line: 975
NekoJonez,
Thank you for reporting these issues. I am going to take a look at using Battle with that theme to see what you are talking about.
Is this the theme you speak of? ... http://custom.simplemachines.org/themes/index.php?lemma=2497
For the db issue, if you can not wait for the next beta then do this manual edit...
file: /Sources/BattleAdminQuests.php
find:
unset($_SESSION['battle_table_status_battle_campaign_' . $campaignId]);
replace with:
unset($_SESSION['battle_campaign_' . $campaignId]);
You may need to manually delete your browser history to clear the sessions (just one time).
Regards.
Yes, it's that theme I speak off. And I will wait for the next beta.
NekoJonez,
The Battle template passes W3C validation and appears ok in most themes but not that one. I tried my other mods with it and they appear ok using a similar HTML table structure. Since I did not originally develop the Battle templates, Imo it may be best if I just start from scratch with them so that they appear proper for all themes. Hopefully this weekend I will find the time to do that.
Wow, I might have to look into that one then.
What are the errors maybe? So I can fix them at my site.
Battle v1.15 Beta3
Download:
http://s000.tinyupload.com/index.php?file_id=35615157322249670445
Changes:
! reorganized/added files due to previous large file sizes causing ftp issues
! added custom template file for freshlooks theme
! fixed unset variable in BattleAdminQuests.php
NekoJonez,
The issue with the freshlooks theme was one style attribute for the css class of normaltext. I changed it to smalltext in a template file that installs into that theme specifically.
Hopefully the file changes will now allow for FTP editing without issue.
The template files still need to be split because I forgot about them so I will do it for the next beta.
Therefore those files may still present an issue when editing via FTP.
Burt,
I will fix the issues reported here: http://www.simplemachines.org/community/index.php?topic=323835.msg3668304#msg3668304
Regards.
No worries, I'm here now anyway, so I'll continue the testing and bug reports here instead of at SMF forum.
Thanks
Burt
Here is another nice idea. What if you can upload custom images for eg the money? It would be nice if I could easily change the bills to coins, when my cash system are gold.
Btw: Epic fixing man. I installed it and it's working perfectly.
Quote from: NekoJonez on February 12, 2014, 12:00:56 PM
Here is another nice idea. What if you can upload custom images for eg the money? It would be nice if I could easily change the bills to coins, when my cash system are gold.
Btw: Epic fixing man. I installed it and it's working perfectly.
You can already do that by changing the money.png file in a manual way offcourse
Hello Underdog
I don't know if this has been mentioned before but if you look at the profile info in the forum you get "Battle Stats:" duplicated 4 times
I attached a picture.
Burt
Burt,
Did you ignore any parsing errors during un-installation at some time when updating the mod? This will occur if it did not remove smf file parsing edits during the uninstall process because when re-installing the mod it places duplicate edits.
Check the SMF files that the installer edits to see if there is duplicate code within one of them. Simply remove all the duplicate code leaving just the single edits. This sounds like the edit it makes to /Sources/Profile-View.php.
Quote from: underdog on February 12, 2014, 09:36:37 PM
Burt,
Did you ignore any parsing errors during un-installation at some time when updating the mod? This will occur if it did not remove smf file parsing edits during the uninstall process because when re-installing the mod it places duplicate edits.
Check the SMF files that the installer edits to see if there is duplicate code within one of them. Simply remove all the duplicate code leaving just the single edits. This sounds like the edit it makes to /Sources/Profile-View.php.
I can't remember if I did got any error while installing, but I did find four duplicate in the Profile_View.php file.
I'll pay more attention next time I un- or install the new version to see if I get parsing errors.
Thank you
Hey Burt...good to see you
Burt..If you need any help getting rid of those duplicated stats...let me know I was up against that in the past.
Burt, SMF along with some hosting issues sometimes cause improper installs/uninstalls. If you've installed/uninstalled a particular mod multiple times it may or may not add/remove all of the code as it should but you may not see any errors. I've seen this many times over the years. Not sure exactly how or why it happens but it does happen on some servers and not others. But I'm pretty sure it has to do with folder/file permissions not being set properly before you install or uninstall a mod. At least in my experiences, it does not happen as much if you make sure they are correct before you start each time. Yeah, it's a pain, but it happens.
So when doing things like this it is best to manually check to make sure duplicates are not added even if you do not see "Test Failed" during installs or uninstalls. If it happens once, it may happen again.
I hope that helps. :)
Skhilled...I've seen this too. If I modified the display.php file and did an update and I would see the stats show up twice. I saw I was getting an error and saw the "Test Failed"
All I did was upload the default display.php file and it solved the issue but I also know how to manually remove it.
Yeah, it varies from server to server. The last hosting I was on did the same a lot with mods. But the current one I'm on seems to work well even if the permissions are improperly set.
I was previously a co-hosting owner some years ago and am staff on a different hosting now. I don't know everything but am very sure it has to do with how the server is configured. The best you can do is try to make sure folder and file permissions are set properly first then install or uninstall...or change hosting. LOL
Well here are some things for you Underdog, keep in mind that these are simply idea's and reports. Do with these what you wish or think is best for the mod.
- There are some minor language issues in the main settings. Like you forgot ":" here and there. Also, one capping of the start of a sentence is forgotten. Also, one option has "max" and the next "maximum", isn't really consistent.
- If it's already not possible: showing images during the custom explore? Eg: when somebody finds a treasure chest.
- When in the battle mod, on the battle page, the who's online shows "Unknown Action".
- (Already suggested, but I don't see it in the to do list. Also, to make this suggestion list more complete) The ability to re-order the shop items.
- Image uploader to allow staff, who don't have access to FTP, to upload custom images for monsters and shop items.
- Ability to choose which menu item battle will appear next to?
- Ability to revive users with eg 50% of their health instead of a set amount.
- Possible inventory to store items bought in the shop and able to use in battle.
- Possible ability to buy items in the multiple items in the store more easily. Like: "Add to cart" - thingy.
- News section, where staff can post the latest updates or changes they did.
- Put the buttons in battle on a fixed position. To avoid people who click without really reading what stats they lost to not click on "run" by accident.
- Possibility to change the text that appears on the buttons ("ok" or "run away")
Sorry guys my bad....
Hi everyone ;D.... and thanks for offering help, but it wasn't really hard to delete 30 line of text....
Now to NekoJones, that's not a bad list you got there... Two weeks of coding just there.... ;)
I would like to expand a bit on your list: In the shop, while I think the "Add to Cart" would be a great solution, maybe just divided the items by categories, that would make it already a lot easier to find things, and definitely your last suggestion. The Buttons need to stop moving and maybe, you should need to press the Attack button just once till the attack is over either way, with a win or with a loss....That would also make more sense in a D&D situation where in reality once you have decide to fight there is no turning back till one or the other is dead...
Also I don't know about you guys, but I don't really thing the Map looks that good. It looks like painted by a 3 years old... ;D Wouldn't be better to have a single large picture to load. Player would still need to click anywhere in the picture, and that would also give us the chance to use a picture related to the theme of the game...
Underdog I have a single request...
Would it be possible to have the "Quest Limit:" to take the digit 0 as unlimited? I know that you can always put a huge number in there, but an unlimited option would be another less thing to worry about when you are setting up large games..
I'm just talking loud here, what ever direction this mod may goes, I will be happy to follow....
Burt
Battle v1.15 Beta4
Download:
http://s000.tinyupload.com/index.php?file_id=05743435859820679963
Changes:
+ added user settings custom hook for Battle
+ added member context custom hook for Battle
! changed file edit to $user_info hook for Battle (existing hook)
! whichever member column is opted will be included in the above changes
! fixed user avatar in Battle template
! edited admin display to only include beta testers that contributed since Battle v1.1+
! fixed install.xml file
I added 2 more custom hooks with this beta version. I did this because it required a bit more code than just adding to those arrays (some conditional logic) and it makes for cleaner edits. I will have to split up the template files another time but it's not so important right now because that will just be to fix the issue people are having with editing large files in FTP. The error I found in the install.xml file may have been the reason why this mod did not always remove all of its manual edits.
This beta will hopefully resolve any issue with using another member column for monetary units. If this is changed, ensure that the name you use is the exact column name from the members table. Some mods do not add the same reference to the $user_info array but what I just wrote should make it work as long as you ensure it is that same column name from that db table. I will add an admin setting check for this in the next beta where it will display an error message and reset the monetary units to gold if one enters something that is not in the members table.
Battle has now been posted in one of my GitHub repositories:
https://github.com/Underdog-01/Battle
Your github avatar is the same one I have on Facebook for the profile I play mafia wars with..LOL
Quote from: underdog on February 14, 2014, 06:35:38 PM
! fixed user avatar in Battle template
Hello Underdog....
Few of my members avatar are still not loading.. I have tried to edit the Battle.template.php to see if I could do some changes but none of the programs I'm using is good enough for editing your .php files... or maybe is Filezilla that does change something...
They alway return the error
Parse error: syntax error, unexpected T_FUNCTION in /home/ilmozzon/public_html/forum/Themes/default/Battle.template.php on line 1
I forgot
Just to be clear. The avatar does load in the main "home" screen above the Welcome warriors.....
Where it doesn't load is in the battle screen where you get a straight vertical line only.
Burt
Burt,
You are looking at the correction I made but it is for the main battle page where you say it works fine.
The display you are referring to is in a different part of the file which I did not know had an issue until now.
Let me explain something in response to your last post to thwart your confusion.
This code:
if (!empty($context['user']['avatar']))
echo '
<p class="avatar">', $context['user']['avatar']['image'], '</p>';
.. asks the condition that if the user has an avatar, display it (partially using theme css).
this code:
else
echo '
<img border="0" src="', $settings['images_url'], '/icons/online.gif" width="50" height="50" alt="', $user_info['name'], '" />';
... only kicks in if the previous was not true (user does not have an avatar selected) whereas it will display a default user image.
If you are saying that different themes use various image types for the default user icon, I can simply have it display an image that can be included in the battle package.
The image that is displayed for user battles is located in a different part of the template file. It needs to be edited to be the same as what was referenced here to fix it which is something I overlooked. I will fix this for the next beta release.
Thank you for the report.
I'm not a genius on this but where you have it highlighted in red can one insert
'icons/online.gif"
or
'foldername/icons/online.gif"
don't be afraid to insert the whole url.
The "/" might be the issue too
I see now too
Quote from: underdog on February 15, 2014, 12:14:24 AM
Burt,
You are looking at the correction I made but it is for the main battle page where you say it works fine.
The display you are referring to is in a different part of the file which I did not know had an issue until now.
Let me explain something in response to your last post to thwart your confusion.
This code:
if (!empty($context['user']['avatar']))
echo '
<p class="avatar">', $context['user']['avatar']['image'], '</p>';
.. asks the condition that if the user has an avatar, display it (partially using theme css).
this code:
else
echo '
<img border="0" src="', $settings['images_url'], '/icons/online.gif" width="50" height="50" alt="', $user_info['name'], '" />';
... only kicks in if the previous was not true (user does not have an avatar selected) whereas it will display a default user image.
If you are saying that different themes use various image types for the default user icon, I can simply have it display an image that can be included in the battle package.
The image that is displayed for user battles is located in a different part of the template file. It needs to be edited to be the same as what was referenced here to fix it which is something I overlooked. I will fix this for the next beta release.
Thank you for the report.
Sorry mate, I went down the wrong direction and waist everybody's time...
I did actually find the right line after, and this is the only bits that I was actually wonder:
$modSettings['custom_avatar_url'] instead of $modSettings['setting_custom_avatar_url']
Could be this the problem...
Hey I'm only guessing and as you know, not that well :D
Burt
Ok now I took the time to read your reply and understood...
No worries...
Burt
As far as I can tell you are talking about users that have not selected an avatar within their profile?
I will change it so Battle includes a custom icon for this (from the default theme actually) and have it use that in both places.
As for when a user has an avatar... I tested a custom package of avatars with different image types, a direct url avatar with different image types and uploaded some avatars with different types and they seem to work fine for me.
Quote from: underdog on February 15, 2014, 12:36:10 AM
As far as I can tell you are talking about users that have not selected an avatar within their profile?
I will change it so Battle includes a custom icon for this (from the default theme actually) and have it use that in both places.
As for when a user has an avatar... I tested a custom package of avatars with different image types, a direct url avatar with different image types and uploaded some avatars with different types and they seem to work fine for me.
No No, that's not what I'm saying at all, I'm one of them and I do have my avatar that shows when I'm in the home screen, but pretty much all the users that have a "Custom" avatar, they don't show in the Attack page. Because the avatars do load in the Home screen, we can safely assume that there is nothing wrong with the avatars. The problem is that, only the "Custom" avatars, that are store elsewhere in the server as per "$modSettings['custom_avatar_url']", they do not load in the attack page (the page where you attack the other members). So I would be inclined to think that the function that calls for the avatar images in the attack page, does not look for the "custom_avatar_url" like the home page does...I hope it make sense
Again just guessing here...
Now on a different note I just reset the game and have these setting (picture 1) and in the game members get these (picture n2) amount of gold to start, that's definitely not enough to play. Where does that 200 comes from?? Is that a way for us to adjust the initial amount of gold in the game?
Thanks
Burt
I know what display you are referring to for battling other members. I have also already informed you that I am not able to duplicate your gold issue (or the custom avatar issue) nor has anyone else reported this to me. Instead of going back & forth like this it might be best just to grant me access to your forum so I can see it for myself. For the gold issue this will most likely include admin access or maybe create a new membergroup to which I am the only member and allow that group battle admin access permissions. That way I can look at all the battle settings to see what is going on.
Atm however, it is bed time so this will have to wait until tomorrow (2am here).. I can barely keep my eyes open.
\\Edit->
Do you have the same avatar issue with the default theme specifically? There is css in that line of code you are having issues with is why I am asking.
$class = $key % 2 == 0 ? 'windowbg' : 'windowbg2';
echo '
<tr>
<td class="centertext ', $class, '" width="25%">
', $avatar = $row['avatar'] == '' ? ($row['id_attach'] > 0 ? '<img src="' . (empty($a['attachment_type']) ? $boardurl . '?action=dlattach;attach=' . $row['id_attach'] . ';type=avatar' : $modSettings['custom_avatar_url'] . '/' . $a['filename']) . '" alt="" width="25" height="25" style="border: 1px solid silver"/>' : '') : (stristr($row['avatar'], 'http://') ? '<img src="' . $row['avatar'] . '" alt="" class="avatar" width="25" height="25" style="border: 1px solid silver"/>' : '<img src="avatars/' . htmlspecialchars($row['avatar']) . '" alt="" class="avatar" width="25" height="25" style="border: 1px solid silver"/>');
if(empty($avatar))
echo '
<img border="0" src="', $settings['images_url'], '/battle/online.gif" width="25" height="25" alt="" />';
Sorry Underdog I already told you before that I cannot do that. Anyway like you said, nobody else has reported these two problem, so lets move on.... :)
Thank you
Burt
Burt,
You can't even supply me with the forum url so that I can register to see the images issue?
Did you try the default theme? All you do is put theme=1 in the url (surrounded by semi-colons)
I bellieve I may have found the issue with the avatars although strangely enough it was working for me. It should have given us an undefined error in the log but did not which is also strange. Somehow that condition was not being triggered for me although I tested with custom uploaded avatars.
Here is a link for download that includes a fix. I did not bother changing the beta designation for this fix.
download:
http://s000.tinyupload.com/index.php?file_id=95018282712536636044
8)
Thanks for adding me to the credits. :3
Anyways, Arpegi (the name of my forum) always uses the latest beta you post. So, on that data I give you the feedback!
From the last beta, two small things. One, the changelog isn't up to date and two, the link to Burt's credit doesn't go to a blank page.
On the other hand, what did you think of my list of idea's Underdog?
NekoJonez,
I like your ideas and take everyone's into consideration. Atm I think it would be best to sort out all the bug fixes prior to implementing anything new because new additions may introduce more things that need honing.
Burt,
If you are using the default gold member column then the only way I can see several members gold set at 200 is if you used the Admin -> Battle -> Members -> Edit Member .. setting gold to 200 at some point & then ticking one of the checkboxes at the top prior to using save on that page. This is the only way I can think of it adjuting those members to 200 gold. The stat settings in the config itself is only for members when they first register prior to playing the game.
I forgot you told me about not being able to grant me that access. I am guessing the forum you are using this on is private and it just makes things easier to look directly at the issue sometimes but nothing can be done about that I suppose. My apologies for asking a second time in error.
Hopefully the last fix solves the avatar issue and now I must concentrate on testing the gold issue to see what problem it may be having. The mod has various adjustments for peoples stats therefore I have to be sure those are set correctly.
Thanks again to all beta testers and donators who help me out.
Regards.
Quote from: underdog on February 15, 2014, 10:17:16 AM
I bellieve I may have found the issue with the avatars although strangely enough it was working for me. It should have given us an undefined error in the log but did not which is also strange. Somehow that condition was not being triggered for me although I tested with custom uploaded avatars.
Here is a link for download that includes a fix. I did not bother changing the beta designation for this fix.
download:
http://s000.tinyupload.com/index.php?file_id=95018282712536636044
:-[ I don't know how to break this to you, but still, no luck. Just for curiosity, last night (at around 3am :) ) I did a test and assign to those 6 members (whom don't have the avatar displayed in the attack page) a avatars for the "avatars" folder, (what I practically did was move their avatar from the custom folder to the avatars folder on the server)and their avatar did show up straight away in the attack page.....
As per the gold issue I'm please to say that it is solved. My problem was the 3600 second (that's 1 hour) in the setting. What happen was that some member did play for a while, then go and do something else, but stay logged in, the come back and just open the home page and voilà, extra cash was becoming instantly available. So practically if the did click on the game 6 times in a day, that would have give them 6000 in gold (as the game was set to 1000 every 3600 seconds). The reason why I was getting so much more it is only because I was spending a lot more time on-line that they did. So I did fix the issue by changing the time from 3600 to 28800 (that's 8 hours).
So this is not a problem any more, but you need to set the time to a realistic number or leave it at 3600 but cut down the amount of gold by a lot, otherwise it does make it a lot harder for players that just log to play for a bit and then log out till the next day...
So my gold issue is SOLVED :D
PS
The forum is at il-mozzo.net It is actually my brother's forum..
The Game is under Games/Mobsters
Burt
Quote from: underdog on February 15, 2014, 05:15:05 PM
Thanks again to all beta testers and donators who help me out.
Regards.
Thank YOU, Underdog, for listening to the community.
If I was better at coding, I would have helped you with the code. All I can do now, is for some things, look at the code and delete spaces that shouldn't be there or bang my head against my desk why I wasn't able to work out something simple as that :P
In all seriousness, you make a great mod and I will do my utter best to catch every bug and think up idea's to improve the battle mod :D
Battle v1.15 Beta5
Download:
http://s000.tinyupload.com/index.php?file_id=38449757807618666993
Changes:
! fixed display of user avatars
! fixed beta tester redirect link
The Battle changelog and GitGub repo has also been updated.
Is this all of the bugs thus far or did I forget something?
NekoJonez,
For language edits, perhaps it would be best to sign up for a GitHub account, create a fork of the Battle mod & issue pull requests (followers are also welcome).
This will allow you to do language file edits on the fly and I can peruse them to ensure they are correct before applying them.
Imo my grammar is fairly good but I do make mistakes.
Regards.
Quote from: underdog on February 16, 2014, 06:12:11 PM
Is this all of the bugs thus far or did I forget something?
NekoJonez,
For language edits, perhaps it would be best to sign up for a GitHub account, create a fork of the Battle mod & issue pull requests (followers are also welcome).
This will allow you to do language file edits on the fly and I can peruse them to ensure they are correct before applying them.
Imo my grammar is fairly good but I do make mistakes.
Regards.
:D Thanks for fixing the avatar... (BTW I like yours.... ;D)
As per above I can help with Italian But I don't know much about GiHub.....
Hmmm there may be still one bug left, but give me some time to test and confirm it.
Back soon...
Burt
I just test everything again and I'm all clear here.
I have no more bug to report from my site but...
Questions?
1) If you have no Defence or Attack points left, but you have points in all the others categories, is that normal that your name is not displayed in the Attack window?
2) If you have no Defence or Attack points left, is that normal that you can still attack other members in the attack window?
If the answer to these 2 is yes, then it is all good and I'm done.... 1.15 Beta 5 is good.
Again, thanks Underdog for pushing this mod so far....
Burt
Burt,
1) People that are dead do not appear in that list, however people with low or 0 atk/def but still have hp should still appear in that list.
2) If you are dead (no hp) you can not attack people. If those other stats are low I will assume you will die when trying to attack someone just one time which you can test. It should just display a message saying your attack points are too low if those specific points are at 0 (please test).
If you want to translate all language file from this mod to Italian that is fine and would be appreciated. The only thing I am worried about is the size of the mod is getting large and including more files might eventually give people a hard time with installing. You can tell this already with the delay in upload time when installing on a website. To get around this problem I can create a language plug-in that adds the appropriate files I suppose and then add translation files to that. Yes, that will work quite nicely.
Quote from: underdog on February 16, 2014, 06:12:11 PM
Is this all of the bugs thus far or did I forget something?
NekoJonez,
For language edits, perhaps it would be best to sign up for a GitHub account, create a fork of the Battle mod & issue pull requests (followers are also welcome).
This will allow you to do language file edits on the fly and I can peruse them to ensure they are correct before applying them.
Imo my grammar is fairly good but I do make mistakes.
Regards.
I might help you fixing the languages then.
Hi Underdog...
Example:
I have 100 HP but 0 atk and 0 def.... My name will not show up in the battle page for others to kill me, but I can still go in the battle page and fight them. It looks like the mod only check your HP points but not the other level such as atk and def in the battle window.
That is what I said in my previous post... I did not mentioned "hp" points. So if this is what you want the Game to do it's fine by me, but I don't understand the logic in how can you attack other members when you have 0 atk and or 0 def. That's all.
Quote
1) If you have no Defence or Attack points left, but you have points in all the others categories, is that normal that your name is not displayed in the Attack window?
2) If you have no Defence or Attack points left, is that normal that you can still attack other members in the attack window?
If you want to see what I mean: edit one of the player and give them 100HP, 0atk and 0def points. Then log into the game (as a different user) and see if you can see their name in the battle page list. Then log in to the game as him and see if you can fight the other people in the list....
Burt ;)
I will take a look at the conditions I put in for battling other members. Imo it should not be allowing one to attack people if the attackers atk points are at 0. I can fix that easily enough. I know you did not mention hp points, it was merely an explanation of how it is intended to work. I most likely forgot to have it check the atk points. 0 def should not matter as one will probably die in the game fairly quick with 0 def points. Imo it is realistic to say that one who jumps into a battle with no form of defense is possible although one will perish soon after.
I neglected to put in some brackets within the mysql query when it searches the db for members to attack. I will release a fix for that in a bit..
I also did not put in the check for the current user for hp, atk or def.
Should I ignore the def points for both or perhaps not let a person battle (attacker or defender) if their def points are at 0 ??
If a defenders atk points are at 0 should they be in the list?
Atk & HP must be above 0 for the attacker no matter what which I understand.
I would like opinions on the setup.
Regards.
Quote from: underdog on February 17, 2014, 11:48:16 PM
I neglected to put in some brackets within the mysql query when it searches the db for members to attack. I will release a fix for that in a bit..
I also did not put in the check for the current user for hp, atk or def.
Should I ignore the def points for both or perhaps not let a person battle (attacker or defender) if their def points are at 0 ??
If a defenders atk points are at 0 should they be in the list?
Atk & HP must be above 0 for the attacker no matter what which I understand.
I would like opinions on the setup.
Regards.
My opinion....
If I have 1 hp and 1 atk and 0 def, then I should be able to be seen in the list and to attack other members...
If I have 1 hp and 0 atk and 1 def, I still should be able to be seen in the list but not to attack other members or monsters...
If I have 1 hp and 0 atk and 0 def, I still should be able to be seen in the list but not to attack other members or monsters...
So yes I agree with you, as you don't need to check on the def points, only the hp and atk. If you have 0 def and try to attack you should die pretty quickly anyway, but you can still inflict some points damage to another player....That's good....
Regards
Burt
Quote from: underdog on February 17, 2014, 02:12:30 PM
Burt,
If you want to translate all language file from this mod to Italian that is fine and would be appreciated. The only thing I am worried about is the size of the mod is getting large and including more files might eventually give people a hard time with installing. You can tell this already with the delay in upload time when installing on a website. To get around this problem I can create a language plug-in that adds the appropriate files I suppose and then add translation files to that. Yes, that will work quite nicely.
Sorry Underdog, I misunderstood what the conversation of the language was about. I got it now. I actually though that you wanted to have this game in more than one language, and I'm still happy to help if you decide to go down that path....
Sorry
Hello...
I was just killing monsters, when I decided to open the Game Stats to see how the other players were doing and I think something is not right with the points...
I attached a picture...
I only killed 6 monsters all up... and it also shows two different scores.
Burt
Epic. It feels like Underdog is the coder, I supply idea's and Burt catches the bugs.
Sweet teamwork ;3
Quote from: NekoJonez on February 19, 2014, 02:43:33 PM
Epic. It feels like Underdog is the coder, I supply idea's and Burt catches the bugs.
Sweet teamwork ;3
You are right...I just hope that Underdog doesn't get tired of this constant fixing bugs. This mod was written so poorly when he first come out, that I always wonder if it wouldn't have been easier to start again from line one. But I did promise to Underdog that I would have been a proper PITA Beta Tester... :) I wish I could help more, because I know how quick it can get stressful, but I'm not good at developing mods. So hopefully, Underdog won't give up on me...
As far as Idea's, I mentioned this to Underdog (but he hasn't see the post, I believe yet), there is -->>THIS (http://www.torn.com/)<-- game online where I think we can take a lots of ideas from..(if we want, that is) :D and if that's the direction that we want to go.... As I said previously, the map, the monsters.... you need more than that to keep members entertained. We need to build a great story first then implement the game to it.... As usual, I'm just talking loud here, and I know that it would take a lot of effort to build something like that for a Forum base game....but it doesn't have to be huge, just be able to keep people busy and you can do that with a good clever story line....
If only, I knew what I'm doing.... ::)
Burt
Campaign quests add bonus points to a game. If the admin opts to combine those points together in the config it will do so for that game.
To double check click on the campaign points to view them and then look at your points to the right hand side. The game stats page should be adding the two of them together and displaying that total.
G'day...
Did some more testing...
On picture 1 after few minutes of playing, my name has gone from Top Attacker by Attack and Top Attacker By Defence....
The only way to get my name back in the list was to go and buy some atk and def points in the shop as per pic n.2
It seem like it doesn't refresh and show your new stats while you are playing, until you change the condition of the stats again to full....(I'm just guessing)
Test was done in Chrome, I'll try again in Firefox and see if any different....
Burt
Quote from: underdog on February 19, 2014, 10:12:30 PM
Campaign quests add bonus points to a game. If the admin opts to combine those points together in the config it will do so for that game.
To double check click on the campaign points to view them and then look at your points to the right hand side. The game stats page should be adding the two of them together and displaying that total.
Hello there...
Sorry forgot that...
If that is the case, than it works...
Now I do have the box tick in the battle config, and as you can see in pic 1 I was given 4090 points...
Now in picture 2, that is the quest setting for that particular campaign. Could you please explain to me, if I have any control over the amount of points given in the campaign, or it is a random generated number?
Thank You
Burt
One last think for today...
The score is correct, no problem there, but shouldn't then my name be in the top of the list, considering the score? Also the blue bar length doesn't look right.... :)
Good Night...
An admin does not have control over the amount of points for each campaign. The points increase for every quest within a campaign depending on the level of a quest which is how each campaign is ordered.
I made an adjustment with the last stable version because I used an anonymous function that is only native to PHP 5.3+ at one point which a few people complained about (ie. they were using PHP 5.2 and got an error). I changed the routine to something that works for previous PHP versions and thought it was functioning properly but apparently it is not. I will take a look & adjust it yet again so it orders the point leaders properly.
Thank you for the reports and testing.
Regards.
Is it me badly installing battle or do we have "Max attack to give to newly registered users :" twice in the main options?
Nvm, I checked just before posting. I saw the mistake. I'll edit it in the github. ; )
I got another bug. Battle doesn't display the correct version of SMF. I have 2.0.7 installed, while battle claims I have 2.0.2
PS: I changed some language stuff in the github for one file. If you think it's better, I'll make the same edits for all other files ;)
Quote from: NekoJonez on February 23, 2014, 10:46:45 AM
I got another bug. Battle doesn't display the correct version of SMF. I have 2.0.7 installed, while battle claims I have 2.0.2
PS: I changed some language stuff in the github for one file. If you think it's better, I'll make the same edits for all other files ;)
That does not use the battle language file to display that info. It uses a db value from the settings table to determine the SMF version. If it says SMF 2.0.2, this would be because you have it installed on a forum that was originally SMF 2.0.2 with patches to update it to SMF 2.0.7. I will look to see another way to determine the smf version.
So, when can we expect the next beta?
Quote from: underdog on February 22, 2014, 04:17:56 AM
An admin does not have control over the amount of points for each campaign. The points increase for every quest within a campaign depending on the level of a quest which is how each campaign is ordered.
I made an adjustment with the last stable version because I used an anonymous function that is only native to PHP 5.3+ at one point which a few people complained about (ie. they were using PHP 5.2 and got an error). I changed the routine to something that works for previous PHP versions and thought it was functioning properly but apparently it is not. I will take a look & adjust it yet again so it orders the point leaders properly.
Thank you for the reports and testing.
Regards.
No problems. I understood and Thank you.
Burt
I do believe that we still have bugs in the campaign department. Problem is, they don't show up all the time, and that makes it a lot harder to fix'em. Ok here we go.
I did the following:
I set up three Member group (A B C) and A can access only Alpha, B can access only Beta and C can access only Delta campaign.
Then I went into the game and set up one quest to the Alpha Campaign. When I tried to access it a month ago it would allow me to click on the blue writing "Do quest" and then give me the screen of the "an error has occurred" "No refreshing is allowed , please go back to Battle Main page". but I didn't refresh. I had just clicked on the blue writing "do quest". Then the problem went away when I got the newer version of battle. At least that is what I believed.
Yesterday I added two new quests. One for Beta and one for Delta. All these quest are set at level 2 and each quest belong to a different Campaign. I'm on level 4 and belong to the Alpha group, so I did expect not to be able to access Beta or Delta campaign, but now even my Alpha campaign is restricted to me. Thinking it was a level problem went in and did changed them all to level 0. No difference. I also tried to set them all to level 4, again no access to any of them. Then I logged in as a new member into the game and bingo, the same screen with the refresh error is back again. After few tries the game now does allow the new member to play the quests (as they are set to level 0), problem is, he's allow to play all of them, regardless of which member group permission he has.
So:
Quests attached to Campaign did only worked if not on level 0 and only when I had one available in the game.
Added two new quest to the other two Campaign and they all become restricted, no matter what level they are set to.
Changed the level of the three quests back to 0 and tried to log in as a new player the error screen was back. Tried again few minutes after and the error screen doesn't come up anymore, but now the new player (that is supposed to have access only to the Gamma Quest), can actually access all three of them....
It would be great if even you NekoJones could try this in your forum and see what you get. Try to set one quest to level 0 and see if you get the error page the first few times you try to access it, and also try to set two or three campaign quest to your current level and see if you can access them.
I can confirm that the Member group restriction does not work as it should, at least here, as the new member was able to complete all three quest that were set in three different campaign. The New member only had permission to the Delta campaign.
Regards
Burt
PS The Pic number three is to show my game where I'm in the Alpha permission group on level 4 and have no access..
Burt have you gone in and changed up permissions?
I created an Alpha Group and a Beta Group...Then you have to go to each member and tweak their account settings to include the new membership group.
This allows you to create teams with your members...
If you disable campaigns and just assign quests to everyone you shouldn't any problems.
Quote from: Fog on February 25, 2014, 11:49:20 PM
Burt have you gone in and changed up permissions?
I created an Alpha Group and a Beta Group...Then you have to go to each member and tweak their account settings to include the new membership group.
This allows you to create teams with your members...
If you disable campaigns and just assign quests to everyone you shouldn't any problems.
Hi Fog...
Yes I have create three new member group (A B C) and I have assign to each one the permissions for each different Campaign (A=Alpha, B=Beta, C=Delta)...
So you reckon disabling the campaign in the game does fix the problem hey... ;D ;D ;D
Thanks Fog.... that was very funny, but I'm trying to test the mod here....
Burt
Ps: I fully updated the uft8 language files.
QuoteThanks Fog.... that was very funny, but I'm trying to test the mod here....
Burt, let me step aside.
UD...You now have Battle Admin control on my site, my users will give you the best feedback on campaign problems.
Thank Fog.. I asked you before actually about your conversion from monster to tank... I don't know what's your Website address is?... I would like to see what you have done with it...
Burt...
Hello Underdog...
This is not a bug but purely a cosmetics problem. The numbers don't line up especially the def column...
That window in questions is the Monster list
Thank You
Burt
Apologies as I was attending to fixing other peoples forums for the last week.
I will be looking into the reports tonight and most likely will post another beta this weekend.
Regards.
That's fine Underdog. Welcome back.
I understand.
Underdog, what happened to my language edits?
NekoJonez,
Your language edits are still within the pull request you created on GitHub. I have not had time as of yet to look them over completely although I have done so briefly. I may apply them but keep in mind that I may not agree with some & not apply them. Do not fret if I do not agree with all of them though & don't be afraid to keep plugging away.
I apologize again for not having time to work on this mod for the past few weeks. A combination of helping others, testing & applying fixes for bugs in SMF 2.1 (that came to my attention from helping others) and a car accident I was involved in >:(
I have been working on it today although I am only looking at the reports right this moment. The only thing I have done so far is add SMF 2.1 support which seems to be working fine atm. This may be released as 2 mods because I think the overall file size is getting too large and I do not want peoples forums to crash with a memory error whilst trying to upload the zip file.
Regards.
Battle v1.15 Beta5
Download:
http://s000.tinyupload.com/index.php?file_id=08887971808243703470
Overall Changes for v1.15 Beta
+ added user settings custom hook for Battle (SMF 2.0.X branch)
+ added member context custom hook for Battle (SMF 2.0.X branch)
+ added SMF 2.1.X branch support
+ added admin->big images for SMF 2.1.X branch
! changed file edit to $user_info hook for Battle (existing hook)
! whichever member column is opted will be included in the above changes
! changed to max atk and max def for stats chart
! fixed user avatar in Battle template
! fixed user avatars in battle members template
! edited admin display to only include beta testers that contributed since Battle v1.1+
! fixed SMF2-1x_install.xml file
! reorganized/added source files due to previous large file sizes causing ftp issues
! added custom template file for freshlooks theme
! fixed unset variable in BattleAdminQuests.php
! fixed adding campaigns issue
! fixed undefined array where no campaigns exist
! fixed shoutbox refresh issue (now redirects to current sub action)
! fixed sub-action icons and titles for Battle Who's Online
! fixed alignment of monsters/enemies data in Battle template
! fixed installation version ranges
! fixed DESC order of tallied game + bonus points
I did not test the tallied game + bonus points or the reported quest issues. Language edits have not been implemented as of yet.
GitHub has not been updated to this version.
Quote from: underdog on March 07, 2014, 04:24:19 PM
NekoJonez,
Your language edits are still within the pull request you created on GitHub. I have not had time as of yet to look them over completely although I have done so briefly. I may apply them but keep in mind that I may not agree with some & not apply them. Do not fret if I do not agree with all of them though & don't be afraid to keep plugging away.
I totally understand and agree man. It's your mod anyways. I'm glad to help btw ;) Shall I check the new languages or shall I leave my pull request?
So, from what I gathered, I think this is the changelog for beta 5
Quote from: underdog on March 08, 2014, 12:53:18 AM
+ added SMF 2.1.X branch support
+ added admin->big images for SMF 2.1.X branch
! changed file edit to $user_info hook for Battle (existing hook)
! changed to max atk and max def for stats chart
! fixed SMF2-1x_install.xml file
! fixed sub-action icons and titles for Battle Who's Online
! fixed alignment of monsters/enemies data in Battle template
! fixed installation version ranges
! fixed DESC order of tallied game + bonus points
Quote from: underdog on March 07, 2014, 04:24:19 PM
I apologize again for not having time to work on this mod for the past few weeks. A combination of helping others, testing & applying fixes for bugs in SMF 2.1 (that came to my attention from helping others) and a car accident I was involved in >:(
Regards.
I wouldn't worry about this stuff. The important thing is that you are ok.. :)
Burt
Quote from: underdog on March 08, 2014, 12:53:18 AM
Battle v1.15 Beta5
I did not test the tallied game + bonus points or the reported quest issues. Language edits have not been implemented as of yet.
GitHub has not been updated to this version.
Hi there...
I still get the score mixed up...
Burt
So, is the v1.15 going to be released soon or do you wait on more testing?
As of late I have been working on other projects such as Avatar Attachments Transer (http://www.simplemachines.org/community/index.php?topic=519978.0) and the Navgoco SP Plugin but I have now finished with both of them for the time being.
I need to fix the issue with the score display. The routine I have for sorting scores that include the quest bonus points should be working properly but apparently it is not. I will have to take a look at it to see what the issue is which I may do today or tomorrow.
Battle v1.15 Beta6
Download:
http://s000.tinyupload.com/index.php?file_id=53550459553454417261
Changes:
! fixed DESC order of tallied game + bonus points
! fixed various language discrepencies
! fixed line endings of all files to ~ Unix /n
! fixed UTF-8 language files to UTF-8 encoding
Burt,
The scores issue should be fixed now.
NekoJonez,
Language edits have been applied and thank you for the PR on GitHub. However, with the amount of changes done locally I am going to just update the repo directly instead of approving the actual PR. I will note in the PR that they were applied though.
Fog,
Do you still have a campaign issue? If so then I will come to your forum to have a look at it. I have tested it and everything seems fine but perhaps I am overlooking something.
The Unix line endings I just applied to all files may remedy the issue that was reported regarding editing files via FTP.
Quote from: underdog on March 29, 2014, 03:08:57 PM
Fog,
Do you still have a campaign issue? If so then I will come to your forum to have a look at it. I have tested it and everything seems fine but perhaps I am overlooking something.
This might be the perfect time to come over and setup a campaign....We have two players that are neck and neck and are bounds and leaps ahead of the other players.
The other players can shift their gears and do a campaign while the other two battle it out...
This will help us all out..
You're all setup to have access to all the settings at this point so tweak it if you want...
I'll have get this current update in place.
Fog,
Ok but I have to ask, have you updated to the latest version where you are asking me to test it?
It doesn't do me much good to test something I may have already fixed or where you possibly altered related files.
Underdog, I think you aren't correct with the numbering of the beta. I think the last beta was 6. Now you release 6 again. I think you had twice beta 5.
PS: Underdog, I'm doing minor clean-up changes here and there. Mostly to text. My coding skills aren't what they used to be. Today for example I updated the change log a bit for you ;)
I think I found a bug.
At my forum we have an event that takes 666 health. I was unlucky and got this event. So I lost all my health. Basically, I died. But I didn't appear in the graveyard...
Quote from: underdog on March 30, 2014, 05:34:07 AM
Fog,
Ok but I have to ask, have you updated to the latest version where you are asking me to test it?
It doesn't do me much good to test something I may have already fixed or where you possibly altered related files.
UD, I have updated it to the latest version.
Here's what I'm having problems with. Making the campaign work for each of the players. It seems I don't have the settings right, I'm not getting an error it's just not playing the same for everyone. So I'm thinking if you were to setup a campaign we'd be able to how the settings are suppose to be and learn from there.
Any help would be great.
Fog
NekoJonez,
Yes I erred on the beta designation back at five.. not matter as we will just continue from here.
As for the changelog, if I add something within the beta packages and then fix it along the way, the beta changes will be posted but not necessarily added to the official changelog. The changelog may just inform of what was added in general or changed from the last official release.
Fog,
You still have an issue with avatars? I thought I fixed that but perhaps not.
Fog,
I have fixed the member avatars for the next beta.
You need to adjust permission settings for each campaign. Currently, none of your campaigns are assigned to any membergroups.
This is done within SMF permissions and not within the Battle admin section. When you add a campaign, the permission setting will appear for it in your smf admin permissions section.
You can view what membergroups are assigned within each campaign at the bottom of: admin -> battle -> campaigns. The help question mark tells you how you should have adjusted that feature.
Set all the membergroups you wish for participating in a campaign if necessary.
I see alpha campaign is set to the Arm Commander group but it is not working for my membergroup which is Battle God.
.. I will check on this tomorrow as it is now time for bed.
OK...I think I have a campaigned setup to start tomorrow for my users.
Quote from: underdog on March 29, 2014, 03:08:57 PM
Battle v1.15 Beta6
Changes:
! fixed DESC order of tallied game + bonus points
Burt,
The scores issue should be fixed now.
Yes it does work nicely now... Thank You
I still have the same problem with the campaign as follow:
I belong to the Alpha Campaign group.
I set two quest both belonging to the Alpha campaign and everything is fine. I can access and play both!
Then I add a Third Quest and I assign that to the Beta campaign
When I log in into the game again this is what I get (Picture Attached)
All Campaign become not accessible to anyone that plays the game.
Is that how it is supposed to work? Can you only have one Campaign running at any given time?
Burt
No it is not supposed to work like that. As long as one has permission to play the campaign, is at the appropriate battle level and the previous level is completed (<-- if set as such) then the next level should be playable. Also each campaign should not be affecting the others. Clearly the routine for the campaigns needs a serious overhaul.
The fix for the battle members list has been posted on GitHub. If you would like to apply it prior to me releasing another beta then do it manually.
I will not be posting another beta until I have applied a possible fix for the campaigns, hopefully I will have time to do that this weekend.
ref.
https://github.com/Underdog-01/Battle/commit/8e91852866e5a29842a707a7a1b6eb4b9217ba32
Quote from: underdog on April 02, 2014, 10:53:18 PM
No it is not supposed to work like that. As long as one has permission to play the campaign, is at the appropriate battle level and the previous level is completed (<-- if set as such) then the next level should be playable. Also each campaign should not be affecting the others. Clearly the routine for the campaigns needs a serious overhaul.
The fix for the battle members list has been posted on GitHub. If you would like to apply it prior to me releasing another beta then do it manually.
I will not be posting another beta until I have applied a possible fix for the campaigns, hopefully I will have time to do that this weekend.
ref.
https://github.com/Underdog-01/Battle/commit/8e91852866e5a29842a707a7a1b6eb4b9217ba32
If you are referring to the avatar in the member list, mine is working fine, as You did fix it in the beta 5. I think we are doing good. I have no problem in waiting for your beta releases...
Thank you
Burt
Quote from: NekoJonez on March 30, 2014, 10:53:52 AM
I think I found a bug.
At my forum we have an event that takes 666 health. I was unlucky and got this event. So I lost all my health. Basically, I died. But I didn't appear in the graveyard...
I think you might have skipped this.
Quote from: underdog on March 29, 2014, 03:08:57 PM
Battle v1.15 Beta6
Download:
http://s000.tinyupload.com/index.php?file_id=53550459553454417261
Changes:
! fixed DESC order of tallied game + bonus points
! fixed various language discrepencies
! fixed line endings of all files to ~ Unix /n
! fixed UTF-8 language files to UTF-8 encoding
Burt,
The scores issue should be fixed now.
NekoJonez,
Language edits have been applied and thank you for the PR on GitHub. However, with the amount of changes done locally I am going to just update the repo directly instead of approving the actual PR. I will note in the PR that they were applied though.
Fog,
Do you still have a campaign issue? If so then I will come to your forum to have a look at it. I have tested it and everything seems fine but perhaps I am overlooking something.
The Unix line endings I just applied to all files may remedy the issue that was reported regarding editing files via FTP.
El fichero a sido borrado del servidor
File is attached.
So, since the move... Has there been a new beta?
I want to request two features.
One, that each user can create "Characters", define a name, perhaps a race, things like that, adding further depth. The 2nd is that battle move to github.
battle is aready on github see
https://github.com/Underdog-01/Battle
Quote from: SilverKnight
... each user can create "Characters" ...
That is a decent idea. I suppose I could set up permission restrictions for that section of the admin and a link to it on the battle page (if permitted to view it).
It will also need an image file upload routine. Unless the admin of the forum throws a bunch of images in the folder to opt from.
Thank you, this is something i have wanted for some time and was looking into doing it myself but it's a fair amount of work.
My other suggestions other than characters would be:
Multiple outcomes to quests ( Two is not enough to avoid stagnation of repeating events )
Monster stats which can be compared to yours for different outcomes, such as a monsters speed\dexterity which can decide who attacks first for example or the outcome on if you could flee.
Monsters\characters having unique attacks\standard attacks, for example a dragon might have a fire attaack, a soldier you meet might shoot you with a bow, essentially different types of damage, this could also provide your character with effects such as being poisoned, fire damage etc.
A jobs\minor quest tab, one that a character trades energy for money, has certain outcomes like a quest, i already do this on my battle but in the main-quest tab.
A town\village biome that you can click on your map, could have multiple uses, friend\enemy town with some minor actions, however to make this work properly it would most likely need to be defined,
Quote from: Napalm on August 23, 2014, 04:37:35 PM
Quote from: SilverKnight
... each user can create "Characters" ...
That is a decent idea. I suppose I could set up permission restrictions for that section of the admin and a link to it on the battle page (if permitted to view it).
It will also need an image file upload routine. Unless the admin of the forum throws a bunch of images in the folder to opt from.
I was thinking sides...
I replace the monsters with WWII Tanks and have done both German Tanks and Russian Tanks Games.
Right now I'm using Total Annihilation units and this Game uses Core and Arm Commanders. These Commanders, build metal extractors and energy makers, then build factories that build weapons.
It would be cool if you could create a Tank Capt. or a Core/Arm Commander ID.
Quote from: SA on August 22, 2014, 02:31:34 PM
battle is aready on github see
https://github.com/Underdog-01/Battle
How different is it from the latest released beta?
NekoJonez,
v1.15-Beta6 is currently the most recent version available.
Both the last version posted in this thread (<-here-> (http://www.web-develop.ca/index.php?topic=70.msg769#msg769)) and the version on GitHub are the same.
Regards.
So, after I reset battle, I can't seem to give permission to all users to play the quests. :c
Did you use the Reset Quests option?
I did... I think.