WebDev

one thing i have noticed..  is that when you Login..

noramly in the past.. after logging in or logging out, the site returns back to the home page (Portal)
or if no portal installed then the forum index is shown..

since i updated to SMF 2.1.7 and Portal 1.40.2

when logging in, the index remains blank, does not show the Portal or the forum

when loging out, the homepage of the forum appears and not the Portal.

somthing else that i have noticed...

the changes that were made in the Sub.php for my Menu..

i have added a few other menu buttons and subbottons..

these do not appear any more..

so i gues there is a Portal.php or a "hook" that takes over the Main Menu out of the sub.php

could someone point me in the right direction pleaseee..  :)

I will look into what was reported.
Does this behavior occur on the default theme?
Are you using a mod to add buttons to the task bar or is it manual edits to Subs.php ?

Yes this happens on the default theme as well, it happens on any theme..

It's a Manuel edit in the subs.php

With the 1.39.8 portal installed all the menu buttons are there..

i have been doing some more testing...
the menu bottons that are mainly involved are the "Home" and "Forum" buttons..

the Home button; sub buttons don't appear when edited in the Sub.php
the Forum button; manual edit, to place the button 4th from left

after the 1.40.2 install the forum button appears 2nd from left..

all other manual edited (or insterted) buttons in subs.php after the home and forum buttons, work as expeted

i have found the code.. in the PortalHooks.php that controls the Home and Forum Buttons
on line 1910 - 1946  comented these lines out..

and my inseted buttons in home and forum works as per Subs.php

the log in Problem still remains..

after login, the index remains blank, it does not show the Portal or the forum

as if the "action" on index or home do not get applyed..

for example as if the set location does not get called

   $setLocation = 'index.php?action=forum';

I have been doing a little more testing.. debugging..

When the login button at the top of the default theme is used to login (java script) window opens for the login..
This version of login returns a blank portal..

If the normal login is used..  index.php?action=login  .. no javascript window
Then the login works as it should do showing the portal..

If the 'user info' block in the portal is active and used for the login..
Then the login works as it should do showing the portal..

Hope this helps to narrow the problem down..

just to report back, and the work arround that i have implemented..

i have removed the Javascript call for the login window of the theme that i am using..

index.template around line 280 you will find;

<a href="', $scripturl, '?action=login" class="', $context['current_action'] == 'login' ? 'active' : 'open','" onclick="return reqOverlayDiv(this.href, ' . JavaScriptEscape($txt['login']) . ', \'login\');">

after the removal of the javascript;

<a href="', $scripturl, '?action=login" class="', $context['current_action'] == 'login' ? 'active' : 'open','">
now the login opens in the center of the portal..  the normal ?action=login..

just incase anyone else is looking for a work arround

I've tested adding navigation links and don't see any issues with it.
There is a an older modification that I updated and can provide to facilitate adding navigation buttons/links and icons.
The license for that mod allows me to provide it here for you.

The login/logout issue you reported is indeed a bug and I am also providing an update in the download section.
My fix for that report differs from anything you posted here in this thread.
If possible, I'm asking that you revert your changes, try the update and report back whether it appears to function properly.

Download -> Ultimate Menu v2.0.3 (https://web-develop.ca/index.php?action=downloads;area=stable_smf_modifications;file=144)

Download -> EhPortal v1.40.3 (https://web-develop.ca/index.php?action=downloads;area=stable_eh_portal;file=2)

Hi Chen Zhen, thanks for the Updated version of the portal..  1.40.3

this works as expected.. thumbs up..

when loging in through the Javascript login window..  the portal is shwon..


the untimate menu mod;  i am having problems..

would you like a seperate thread for this problem..?
PHP 8.3.0 is a must..
icons not uploading..
can not create a normal "child of" menu..

i would have preferd to modify my last post..

with php 8.3.30 i can now make buttons..  but the icons will not upload..

The image files must be file types jpg or png.
Can you attach one of the icons you are attempting to use?

the icons that i am trying to use, are attached..

they are based on the size and type as your ep_home and ep_forum icons

another thing that i have noticed with the portal.. "BUG" .. ?

if articals are enabled, and to be shown on the "Front Page Articles" and the database does not have any Articales.

then when loging In, the portals front page returns blank..!


if there is an Articel in the Database, then, when loging In, the portals front page refurns only the Artical, no blocks

At the moment Ultimate-Menu only requires PHP 8.0, although recently I've come across a function I want to use that is only native to PHP 8.3+.
I originally put that version requirement because previous PHP versions are now EOL and pose a security risk.

---

Perhaps I didn't take into account file names with accented characters as per one of your attached images.
Uninstall that mod & install the attachment which has some changes that may resolve what you reported.

---

Quoteif articals are enabled, and to be shown on the "Front Page Articles" and the database does not have any Articales.

then when loging In, the portals front page returns blank..!


if there is an Articel in the Database, then, when loging In, the portals front page refurns only the Artical, no blocks

Yes, when I was putting in the last fixes I came across that problem.
If there is no action argument in the URL, it defaults to the articles template which is incorrect behavior.
I'll look  into fixing that within the next week.. likely on the weekend.
 

yes i agree with you, better to have the security risks mimimised..

sorry to say, i am still getting the same error when uploding the icons..

/Sources/Class-UltimateMenu.php (Line 670)

imagecreatetruecolor(): Argument #1 ($width) must be of type int, float given

Thanks for reporting this problem.
I should have ran a test environment without Imagick to notice these errors or at least force the use of the GD library.

Try the attachment..

the icons now get uploaded.. and renamed.. as you can see in the attached image

but looking at them in the "manage menu" and then "Modify" you have a broken image
right click on the broken image "open image in new tab" you get a 500 Internal Server Error


looking at the database, they seem to be there..!

I can't reproduce this problem at the moment as it seems to open the image for me without any problem.
One would think that if it's writable then it's readable.
Perhaps the .htaccess is somehow causing a problem.
With the mod installed, use your FTP platform (or PC/Mac file manager if you're local testing) to delete the .htaccess file located in ./Themes/default/images/um_icons
Please let me know if this resolves the problem.

That did the trick.. ;)

I am testing on a localhost at present.. getting things ready to go live..
Wampserver64
Apache 2.4.58
PHP 8.3.30
MariaDB 10.6.15
I can change any of theses settings..

Renamed the htacces file..
With copy and paste..
placed my icons in this location Themes/default/images/um_icons..
I see them in the list to choose from..

And hey presto.. all looks fantastic..
After all that, I didn't need the upload..  ;)

Thanks for the prompt response and replys..
I would like to contribute, but sending CAD from Europe.. :(
If there is anything I can do.. :D

The PayPal donation link is for U.S. funds and any currency conversion costs are taken out of it which means WebDev absorbs that cost.
All the server transactions come out of that account so it goes directly into helping pay for running the site.

A link is available in the forum under the "Webdevelop" header and any help in that regard is voluntary and highly appreciated.
I never ask for that though and will contribute to the SMF community in this manner so long as I can afford it.