SMF 2.0 - Enable PHP7.2+ Compatibility version 1.3

Started by Chen Zhen, May 17, 2018, 11:37:29 pm

Previous topic - Next topic

Skhilled


Chen Zhen


No problem.

I updated that thread with one instruction I forgot to initially include.
The actual downloading of the kernel update.. oops.
It is edited now to include that command.

rty42

Hi!

I have tried to apply this MOD to my forums, but the big replacement block in subs.php fails to apply automatically (as I have BBC adding plugin).
Would you consider breaking up that big block to single create_function -> anon function replacements?
That way added bbc blocks would not prevent installation.

Of course added bbc blocks would not and could not be fixed by the MOD, but the original stuff would be corrected.

Chen Zhen

Doing it that way will be a lot of work.
There are many lines to be edited and it was easier to do them in bulk.

How many bbc mods have you added?
If it is few, would you consider using one of the custom bbc mods to add them instead?
Custom bbc or personalized bbc will allow you to add bbcodes.
Since they both use hooks to add them, this will not effect the parsing of the Subs.php file.

rty42

It's only a single youtube MOD per site, but for historical reasons it's two different youtube MODs on the two forums :(

I hoped it was easy to break up the block, but if it's complicated I'll give a try to a different approach.